Reenable GitHub Actions builds #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnutt
force-pushed
the
reenable-github-actions
branch
9 times, most recently
from
0255e09
to
6372d8b
Compare
annulen
reviewed
Jul 2, 2023
.github/workflows/build_cmake.yml
Outdated
|
|
||
| - name: Configure (Linux) | ||
| if: runner.os == 'Linux' | ||
| shell: bash --noprofile --norc -eo pipefail -x {0} | ||
| run: cmake $cmake_args -H. -Bbuild -GNinja -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} | ||
| run: cmake $cmake_args -H. -Bbuild -GNinja -DPORT=Qt -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} |
There was a problem hiding this comment.
It would be better to bring back 4ba116a and avoid using -PORT=Qt everywhere. Also, users would be less eager to trying building with different port value (which is likely going to fail)
annulen
reviewed
Jul 2, 2023
| @@ -34,8 +34,11 @@ extern "C" { | |||
| GDBusNodeInfo* g_dbus_node_info_ref(GDBusNodeInfo*); | |||
| void g_dbus_node_info_unref(GDBusNodeInfo*); | |||
| }; | |||
|
|
|||
| #if !PLATFORM(QT) | |||
There was a problem hiding this comment.
This change certainly belongs to a separate commit
There was a problem hiding this comment.
Definitely. My plan is to try to get the builds working and then extract out the work separately. I only have CI to reproduce this so need to rewrite history anyway.
mnutt
force-pushed
the
reenable-github-actions
branch
from
6372d8b
to
4a65af1
Compare
mnutt
force-pushed
the
reenable-github-actions
branch
from
4a65af1
to
1468f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
movableink/webkituses themasterbranch; enable GitHub Actions to run against it.