Changed processing_thread_ spin to use std::make_unique instead of new #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping in improving MoveIt and open source robotics! |
|
I'm going to close and re-open this PR to trigger Travis again. I'm not sure why it didn't run. |
This comment has been minimized.
This comment has been minimized.
jliukkonen
approved these changes
Nov 14, 2020
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
7 tasks
Closed
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
Apr 29, 2021
Merged
tylerjw
pushed a commit
to tylerjw/moveit
that referenced
this pull request
May 3, 2021
tylerjw
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
moveit_core/background_processing/src/background_processing.cppto usestd::make_uniqueinstead ofnewwhen spinning a background processing thread as mentioned in #2383 and #1411 .