Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveIt Python Library: Migrate Pybind11 Docstrings to Header files #1945

Open
peterdavidfagan opened this issue Feb 13, 2023 · 2 comments
Open
Assignees
Labels
persistent Allows issues to remain open without automatic stalling and closing.

Comments

@peterdavidfagan
Copy link
Member

peterdavidfagan commented Feb 13, 2023

Background

High Priority: the docstrings in their current form are fairly haphazard, it is important to complete this task.

Currently we define docstrings for the Python API within the source code for the pybind11 python bindings example. This task involves migrating the docstrings to header files.

Instructions

Follow up on this investigation by @JafarAbdi:

source

I think it will be difficult to maintain the docs in the bindings. So, I started playing with https://github.com/pybind/pybind11_mkdoc during the weekend to auto-generate the docs from the header files, I did also port the robot_state binding one JafarAbdi@85b1f99. What do you think of this (cc @rhaschke)? I'm more than happy to port the other files.

Another tool worth trying is https://github.com/sizmailov/pybind11-stubgen. I haven't used it, yet, though!

@JafarAbdi I am not sure if you wish to follow up on this issue yourself, I am posting here for tracking purposes. I think this should be addressed in a separate pr to the current one. What are your thoughts?

@JafarAbdi JafarAbdi self-assigned this Feb 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Apr 3, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 45 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
@JafarAbdi JafarAbdi reopened this May 23, 2023
@JafarAbdi JafarAbdi added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

2 participants