CMake format and lint in pre-commit

[tylerjw]

• cmake-format
• cmake_lint
• Drop ament_lint_cmake

Description

I think it is a much better developer experience having cmake consistently formatted and linted in pre-commit than in ament.

[codecov]

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (d962501) 50.74% compared to head (b830011) 41.08%.
Report is 6 commits behind head on main.

Files	Patch %	Lines
...default_capabilities/get_group_urdf_capability.cpp	0.00%	23 Missing ⚠️
...nning_scene_monitor/src/planning_scene_monitor.cpp	40.00%	3 Missing ⚠️
.../rdf_loader/include/moveit/rdf_loader/rdf_loader.h	0.00%	2 Missing ⚠️
...py/src/moveit/moveit_ros/moveit_cpp/moveit_cpp.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
- Coverage   50.74%   41.08%   -9.66%     
==========================================
  Files         392      690     +298     
  Lines       32553    56237   +23684     
  Branches        0     7288    +7288     
==========================================
+ Hits        16517    23098    +6581     
- Misses      16036    32976   +16940     
- Partials        0      163     +163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjahr]

Awesome, thank you! For some reason, this change leads to a huge amount of failures like this:

- moveit_core.cpplint whitespace/line_length [2] (/home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_core/collision_detection_bullet/src/bullet_integration/bullet_utils.cpp:226)
  <<< failure message
    Lines should be <= 100 characters long

Do you know why this is happening? Once it is fixed, we can merge this

[tylerjw]

Awesome, thank you! For some reason, this change leads to a huge amount of failures like this:

- moveit_core.cpplint whitespace/line_length [2] (/home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_core/collision_detection_bullet/src/bullet_integration/bullet_utils.cpp:226)
  <<< failure message
    Lines should be <= 100 characters long

Do you know why this is happening? Once it is fixed, we can merge this

Yea, I do and I'll fix it.

[tylerjw]

Here is the list of linters that come from ament_lint. Now that we are dropping cmake-lint and using it in pre-commit none of these make much sense for us so I'm going to drop all of them.

https://github.com/ament/ament_lint/blob/rolling/ament_lint_common/doc/index.rst