-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port planning scene ros api tutorial #74
Port planning scene ros api tutorial #74
Conversation
vatanaksoytezer
commented
Apr 15, 2021
- Port planning scene ros api tutorial and adresses Port "Planning Scene ROS API" tutorial #8
- Needs Fix move group namespace and demo.launch.py #69 s demo.launch.py to work as expected
Also there seems something wrong with ros2 run moveit_ros_planning moveit_print_planning_scene_info. Which gives me: [INFO] [1618491970.223003091] [print_planning_scene_info]: Getting planning scene info to print |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @vatanaksoytezer.
Is there a fix/issue open for getting moveit_print_planning_scene_info
to work?
|
||
visual_tools.prompt("Press 'next' in the RvizVisualToolsGui window to continue the demo"); | ||
prompt("Press 'next' in the RvizVisualToolsGui window to continue the demo"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to change the prompt prints to not include RvizVisualToolsGui
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were actually not working as intended for me, so I used the normal function one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last time I checked rviz_visual_tools GUI had not been ported to ROS2.
In the other tutorials I ported I commented out the visual_tools.prompt
and added my own to make it easy to re-enable when it gets added back in. It's up to you if you want to do the same approach here...
prompt("Press 'Enter' to start the demo");
/* visual_tools.prompt("Press 'next' in the RvizVisualToolsGui window to start the demo"); */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure, I can make it that way.
Co-authored-by: Marq Rasmussen <marq.razz@gmail.com>
Yeah, I've talked this with @JafarAbdi , I wrote the todo for it but I forgot to open up the issue. Will open today. He has mentioned he knew what the problem is and will fix it when he has some spare time to work on that. See #76. |