Refactored perception pipeline tutorial from ros1 to ros 2 #906
Conversation
|
Just for friendly pinging, @sjahr |
| <param name="max_range" type="double" value="5.0" /> | ||
| Get The Necessary 3D Pointcloud Data For Octomap Creation | ||
| --------------------------------------------------------- | ||
| In this tutorial, you can use `previously recorded 3D pointcloud data <https://drive.google.com/file/d/1fPtDAtJKIiw2gpFOOwA2TrPZOfFU053W/view?usp=sharing>`_ or you can record your own bag file. For recording bag, firstly, it can be both ran ``depth_camera_envrionment.launch.py`` and recorded bag using following commands. |
There was a problem hiding this comment.
I wouldn't use your personal cloud. We could add the file to an additional repository with git lfs to store it. How big is it?
There was a problem hiding this comment.
Agree, but unfortunatelly the bag size is approximately 56MB. I will try to record this bag file in lower size. Do you have any suggestion about it? I'm not sure git lfs works here. Btw i have a question. Do you really use git lfs? It seems git lfs is not used in this repository.
doc/examples/perception_pipeline/perception_pipeline_tutorial.rst
Outdated
Show resolved
Hide resolved
Good question 🤔 did you use the sdf or the mesh file or both? |
- Added new video demo in webm format
- Removed youtube video link
- Renamed moveit2_tutorials instead of ${PROJECT_NAME} in CMakeLists.txt
- Fixed the typo
I had added Intel's license content to mesh file like below. I used their mesh file
The most of the sdf is mine however i just took some camera measurement from them. If it is boring in your perspective, I can remove it. |
Description
I have a PR for refactoring perception pipeline tutorial based on ROS 2. But i have several question about my PR.
I used some external links for not storing big files such as video, bag file which is created by me. Is it okay to give a link to my google drive for bag file and a link to Youtube video for perception pipeline demonstration or should i change these links?
I used Intel's sdf file in the tutorial which the relevant repository has Apache 2.0 License. Does that occur any problem for this organization? Btw, ros2/launch has also Apache 2.0 License. But it is not indicated in this repository. I need a feedback for this situation.
Checklist