-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Python 3 #21
Conversation
Some functions (PyInt_AsLong and PyString_FromString) used in Python 2 are deprecated in Python 3. This changes are needed if you would like to build your project with Python3 support.
When building I found also a problem with rviz_visual_tools package. It does not found method: clearAllTransforms from tf_visual_tools.h |
Changed the way of conversion char to wchar_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We should definitely support Python 3, so this is very useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not tested this, but it looks good. Side note: maybe we should discuss what ROS version we're targeting. (I'd vote Noetic, since Ubuntu 20.04 comes with OpenCV 4.2.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, I second targeting a Noetic release of this package. @JStech maybe you can help me by leading releasing moreit_calibration with the reset of the moveit packages this cycle. Here is a link to the instructions.
The specific tests you could help compete to shepherd this being released are:
- Create the release issue
- Update changelogs
- Prepare announcements
- Test moveit_calibration on Ubuntu 20.04 with Noetic
I am happy to do the bloom steps.
I did finally get a 20.04 installation up and running, and I was able to test this in Noetic and Python 3. There were two other things I had to do to get it all to work, but this change was sufficient within the repo. Besides this change, I also:
So yeah, no changes requested for this PR. This felt like the right place to document what it takes to run in Python 3. |
My course project team is working on the hand eye calibration on noetic today and rviz kept complaining solver can’t return result until we followed what @JStech suggested. |
The CRI Group packages, baldor and handeye, have now been released for noetic, so you can just |
Some functions (PyInt_AsLong and PyString_FromString) used in Python 2 are deprecated in Python 3. This changes are needed if you would like to build your project with Python3 support.