Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Python 3 #21

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Added support for Python 3 #21

merged 3 commits into from
Oct 7, 2020

Conversation

Jakubach
Copy link
Contributor

Some functions (PyInt_AsLong and PyString_FromString) used in Python 2 are deprecated in Python 3. This changes are needed if you would like to build your project with Python3 support.

Some functions (PyInt_AsLong and PyString_FromString) used in Python 2 are deprecated in Python 3. This changes are needed if you would like to build your project with Python3 support.
@Jakubach
Copy link
Contributor Author

When building I found also a problem with rviz_visual_tools package. It does not found method: clearAllTransforms from tf_visual_tools.h
I solved this by installing rviz_visual_tools package from source

@Jakubach Jakubach marked this pull request as draft August 14, 2020 13:51
@Jakubach Jakubach marked this pull request as ready for review August 14, 2020 13:51
Copy link
Contributor

@JStech JStech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should definitely support Python 3, so this is very useful.

@Jakubach Jakubach requested a review from JStech August 21, 2020 09:18
Copy link
Contributor

@JStech JStech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested this, but it looks good. Side note: maybe we should discuss what ROS version we're targeting. (I'd vote Noetic, since Ubuntu 20.04 comes with OpenCV 4.2.)

@JStech JStech requested a review from RoboticsYY August 26, 2020 02:40
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, I second targeting a Noetic release of this package. @JStech maybe you can help me by leading releasing moreit_calibration with the reset of the moveit packages this cycle. Here is a link to the instructions.

The specific tests you could help compete to shepherd this being released are:

  1. Create the release issue
  2. Update changelogs
  3. Prepare announcements
  4. Test moveit_calibration on Ubuntu 20.04 with Noetic

I am happy to do the bloom steps.

@JStech
Copy link
Contributor

JStech commented Oct 6, 2020

I did finally get a 20.04 installation up and running, and I was able to test this in Noetic and Python 3. There were two other things I had to do to get it all to work, but this change was sufficient within the repo.

Besides this change, I also:

So yeah, no changes requested for this PR. This felt like the right place to document what it takes to run in Python 3.

@tylerjw tylerjw merged commit d88c717 into moveit:master Oct 7, 2020
@mfkenson
Copy link

My course project team is working on the hand eye calibration on noetic today and rviz kept complaining solver can’t return result until we followed what @JStech suggested.

@JStech
Copy link
Contributor

JStech commented May 18, 2021

The CRI Group packages, baldor and handeye, have now been released for noetic, so you can just apt install ros-noetic-handeye ros-noetic-baldor (or use rosdep install) and you're good to go. Hopefully soon you'll also be able to apt install ros-noetic-moveit-calibration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants