Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add some clarifying info to MoveGroup tutorial #37

Closed
mcevoyandy opened this issue Oct 23, 2016 · 2 comments
Closed

Please add some clarifying info to MoveGroup tutorial #37

mcevoyandy opened this issue Oct 23, 2016 · 2 comments

Comments

@mcevoyandy
Copy link
Contributor

mcevoyandy commented Oct 23, 2016

I find these lines extremely confusing. Could someone could unpack them into something more readable / understandable? Maybe the first is a really efficient way to do it, but it doesn't seem appropriate for a tutorial. JointModelGroup and RobotModel aren't discussed at all so the tutorial also seems very incomplete.

offending lines:
https://github.com/ros-planning/moveit_tutorials/blob/kinetic-devel/doc/pr2_tutorials/planning/src/move_group_interface_tutorial.cpp#L145

https://github.com/ros-planning/moveit_tutorials/blob/kinetic-devel/doc/pr2_tutorials/planning/src/move_group_interface_tutorial.cpp#L187

This portion could also use some clarification:
https://github.com/ros-planning/moveit_tutorials/blob/indigo-devel/doc/pr2_tutorials/planning/src/move_group_interface_tutorial.cpp#L167

I had thought that z_axis_tolerance = 3.14159 would mean that I just want the joint parallel to the floor, but making this change causes the solution to fail every time. What do these tolerances actually do and how would you use them to do something like "keep joint parallel to floor?"

@davetcoleman
Copy link
Member

davetcoleman commented Oct 24, 2016

I can address this after #38 is merged

@davetcoleman
Copy link
Member

#42

I've cleaned up that tutorial, though I'm not sure what to say about the axis constraints because I haven't used them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants