Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job with minimal dependencies #40

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Jun 7, 2024

Added CI job with minimal dependencies based on the Docker image storm-basesystem:minimal_dependencies. This requires manual builds of CLN and GiNaC, and therefore should detect issues such as #38.

I bumped CLN and GiNaC to the latest version. I also considered using the provided archives instead of the git repositories but they only provide an archive for the latest version and not previous versions. I expect that this would lead to issues for each new release of CLN/GiNaC.

The CI job detected multiple issues:

  • the patch step of Eigen requires a valid git committer which is now configured during the patch step. This should make the commit in CI job with minimal dependencies storm#520 obsolete.
  • use Python3 for GiNaC build
  • use CMake for Cln and GiNaC instead of autotools. This makes the build process easier and allows to only build the library instead of everything (documentation, examples, tests, etc.)

@volkm volkm marked this pull request as ready for review June 7, 2024 13:08
@volkm volkm requested a review from sjunges June 12, 2024 15:00
@volkm
Copy link
Contributor Author

volkm commented Jun 12, 2024

Also enabled CLN and GiNaC for Apple Silicon again as the the latest CLN 1.3.7 supports ARM.

@volkm
Copy link
Contributor Author

volkm commented Jun 26, 2024

I suggest to merge this before the next release, but it is not strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant