Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm without SMT-Checker #282

Open
sjunges opened this issue Sep 1, 2022 · 4 comments
Open

Storm without SMT-Checker #282

sjunges opened this issue Sep 1, 2022 · 4 comments
Labels

Comments

@sjunges
Copy link
Contributor

sjunges commented Sep 1, 2022

From some conversation, I think there may be an issue when installing storm without an SMT solver.

This can certainly be fixed, but it made me wonder whether we still want to have this as an optional setting. In terms of bringing down configurations, it may be nice to make a SMT solver a requirement (currently, Z3, I guess).

@volkm
Copy link
Contributor

volkm commented Sep 1, 2022

In principle, Storm should work without an SMT solver (although we never really test it). The documentation strongly recommends having Z3 though: "not strictly required, but already needed for standard tasks like PRISM/JANI model building".
For the DFT parts, an SMT solver should not really be required. So still keeping it optional would be preferable?

@sjunges
Copy link
Contributor Author

sjunges commented Sep 1, 2022

I understand that some parts can be done without an SMT solver, but I dont think installing an SMT solver is a big hurdle. On other hand, I can understand if you want to keep the dft part easy.

In that case, can we add such a config to CI? Maybe not to the CI checks that run on every check, but still, I dont think any of the developers is testing for these cases.

@sjunges sjunges added the ci label Nov 19, 2023
@sjunges
Copy link
Contributor Author

sjunges commented Apr 5, 2024

In an email, we got:

BTW, in "general dependencies" you mention z3 as "recommended" but to build
BeliefExplorationPomdpModelCheckerTest.cpp
z3 is indeed required. It throws an error, not just a warning ;-)

this can of course also be fixed by fixing this test.

@AlexBork
Copy link
Contributor

AlexBork commented Apr 6, 2024

In an email, we got:

BTW, in "general dependencies" you mention z3 as "recommended" but to build
BeliefExplorationPomdpModelCheckerTest.cpp
z3 is indeed required. It throws an error, not just a warning ;-)

this can of course also be fixed by fixing this test.

I have not been able to reproduce the error using the main branch when disabling Z3 support on my machine. The tests where this is relevant in BeliefExplorationPomdpModelCheckerTest.cpp should not be compiled when Z3 is not available. Any idea if anything else might cause it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants