Improve exception safety with smart pointers

[elfring]

Would you like to wrap any pointers with the class template “std::unique_ptr”?

[sjunges]

Not any, but we do of course welcome increased memory safety.

[elfring]

💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

[sjunges]

We welcome pull requests that improve the code quality. Integrating CI based on clang-tidy is not a priority right now.

[elfring]

🔮 Will a special data representation trigger another bit of collateral evolution?

storm/src/storm-gspn/parser/GspnParser.cpp

Lines 15 to 74 in 66981bb

	storm::gspn::GSPN* GspnParser::parse(std::string const& filename, std::string const& constantDefinitions) {
	#ifdef STORM_HAVE_XERCES
	// initialize xercesc
	try {
	xercesc::XMLPlatformUtils::Initialize();
	} catch (xercesc::XMLException const& toCatch) {
	// Error occurred during the initialization process. Abort parsing since it is not possible.
	STORM_LOG_THROW(false, storm::exceptions::UnexpectedException, "Failed to initialize xercesc\n");
	}
	auto parser = new xercesc::XercesDOMParser();
	parser->setValidationScheme(xercesc::XercesDOMParser::Val_Always);
	parser->setDoNamespaces(false);
	parser->setDoSchema(false);
	parser->setLoadExternalDTD(false);
	parser->setIncludeIgnorableWhitespace(false);
	auto errHandler = (xercesc::ErrorHandler*)new xercesc::HandlerBase();
	parser->setErrorHandler(errHandler);
	// parse file
	try {
	parser->parse(filename.c_str());
	} catch (xercesc::XMLException const& toCatch) {
	auto message = xercesc::XMLString::transcode(toCatch.getMessage());
	// Error occurred while parsing the file. Abort constructing the gspn since the input file is not valid
	// or the parser run into a problem.
	STORM_LOG_THROW(false, storm::exceptions::UnexpectedException, message);
	xercesc::XMLString::release(&message);
	} catch (const xercesc::DOMException& toCatch) {
	auto message = xercesc::XMLString::transcode(toCatch.msg);
	// Error occurred while parsing the file. Abort constructing the gspn since the input file is not valid
	// or the parser run into a problem.
	STORM_LOG_THROW(false, storm::exceptions::UnexpectedException, message);
	xercesc::XMLString::release(&message);
	} catch (...) {
	// Error occurred while parsing the file. Abort constructing the gspn since the input file is not valid
	// or the parser run into a problem.
	STORM_LOG_THROW(false, storm::exceptions::UnexpectedException, "Failed to parse pnml file.\n");
	}
	// build gspn by traversing the DOM object
	parser->getDocument()->normalizeDocument();
	xercesc::DOMElement* elementRoot = parser->getDocument()->getDocumentElement();
	if (storm::adapters::XMLtoString(elementRoot->getTagName()) == "pnml") {
	STORM_LOG_WARN_COND(constantDefinitions == "", "Constant definitions for pnml files are currently not supported.");
	PnmlParser p;
	return p.parse(elementRoot);
	} else if (storm::adapters::XMLtoString(elementRoot->getTagName()) == "project") {
	GreatSpnEditorProjectParser p(constantDefinitions);
	return p.parse(elementRoot);
	} else {
	// If the top-level node is not a "pnml" or "" node, then throw an exception.
	STORM_LOG_THROW(false, storm::exceptions::UnexpectedException, "Failed to identify the root element.\n");
	}
	// clean up
	delete parser;
	delete errHandler;