Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a command to lint all the libs #170

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

seog-jun
Copy link
Contributor

@seog-jun seog-jun commented Oct 20, 2023

Fixes #162
@GabrielCTroia

This is the PR to add the command lint-all-libs to the package.json, but there are some errors on a couple of files. I assume that the issues are already created for the failed files. I'd like to move on the issue to solve the error. Please review the PR, this is pretty short and straight-forward!

Thanks

@GabrielCTroia
Copy link
Contributor

GabrielCTroia commented Oct 20, 2023

Thank you @seog-jun! This looks good! I’m going to merge it shortly!

And yes, thank you for letting me know about the failing. That issue got introduced by mistake and already is part of pending PR!

Lastly, could you please give is a star, so we can bump Movex up the #hacktoberfest ladder a bit! 😁🙏

@GabrielCTroia GabrielCTroia merged commit 3198ac1 into movesthatmatter:main Oct 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[project] Add command to run the linter
2 participants