Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOSED unable to merge [libs/movex] Clean up code in MovexMasterServer file #93

Closed
wants to merge 8 commits into from

Conversation

rabroldan
Copy link
Contributor

Closed the cold issue and reopen for cleaner commit

@rabroldan rabroldan changed the title [libs/movex] Clean up code in MovexMasterServer file #86 new PR request [libs/movex] Clean up code in MovexMasterServer file new PR request Oct 11, 2023
@rabroldan rabroldan changed the title [libs/movex] Clean up code in MovexMasterServer file new PR request [libs/movex] Clean up code in MovexMasterServer file Oct 11, 2023
@GabrielCTroia
Copy link
Contributor

GabrielCTroia commented Oct 11, 2023

Hey @rabroldan, thanks for creating a new PR, but unfortunately I see that the older commits are still here and unverified. I think the best would be to open a new branch off of main and only cherry-pick the last commit in, since that is the one that is verified. This way you avoid pushing the older unverified commits and keep things clean as well.

Here's a quick cherry-pick tutorial https://stackoverflow.com/a/9339460/2093626

@rabroldan rabroldan closed this Oct 11, 2023
@rabroldan rabroldan changed the title [libs/movex] Clean up code in MovexMasterServer file CLOSED unable to merge [libs/movex] Clean up code in MovexMasterServer file Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants