Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Headers #19

Closed
aniketmitra001 opened this issue Oct 3, 2020 · 1 comment · May be fixed by #17
Closed

Refactor Headers #19

aniketmitra001 opened this issue Oct 3, 2020 · 1 comment · May be fixed by #17
Assignees
Labels
enhancement New feature or request

Comments

@aniketmitra001
Copy link
Collaborator

The examples/include/GeometryBackendTraits.h header file is now supposed to be included in py/movetk_geometry.cpp. Also tutorials/TrivialGeometry.h is similar to examples/include/GeometryBackendTraits.h
So have one copy of GeometryBackendTraits.h and place it under src/include/movetk/utils

While you are at it move Geolife.h, GeolifeProbeTraits.h,GeolifeTrajectoryTraits.h, HereProbeTraits.h, Algorithms.h to src/include/movetk/utils as these are specialisations of various traits classes in the library and are mainly a collection of utility headers for the application developer

@aniketmitra001 aniketmitra001 added the enhancement New feature or request label Oct 3, 2020
@aniketmitra001 aniketmitra001 self-assigned this Oct 3, 2020
@aniketmitra001 aniketmitra001 added this to To do in Release v1.0 via automation Oct 3, 2020
@aniketmitra001 aniketmitra001 linked a pull request Oct 3, 2020 that will close this issue
@aniketmitra001 aniketmitra001 moved this from To do to In progress in Release v1.0 Oct 3, 2020
aniketmitra001 added a commit that referenced this issue Oct 4, 2020
Signed-off-by: Aniket Mitra <aniket.mitra@here.com>
@aniketmitra001
Copy link
Collaborator Author

Fixed...
All changes on the python-bindings branch

Release v1.0 automation moved this from In progress to Done Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Release v1.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant