New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unauthed dir
+ language refactor
#1297
Conversation
2516bdc
to
62a9c44
Compare
347a6bd
to
0042ab3
Compare
09298bc
to
530ae03
Compare
93c4f62
to
421f926
Compare
05792a0
to
3a82213
Compare
|
dir
+ language refactordir
+ language refactor
I put the branch as WIP as it seems that several things were not tested properly, once you're done please remove the 'WIP' in the title |
3a82213
to
6dfd31d
Compare
dir
+ language refactordir
+ language refactor
@edhelas Yes, I had accidentally ran a cached version late last night when I ‘tested’ it & saw it running correctly. I was in the middle of fixing it when you caught it. Currently I ran uncached with Brazilian Portuguese & Hebrew being the import test languages (+ region, RTL). |
One sec. I see I have some things indented not the same as other (EditorConfig couldn’t cover PHP) |
d56531f
to
1dc53b0
Compare
1dc53b0
to
17551db
Compare
84fe782
to
b97c8d3
Compare
I didn’t realize that
dir
was missing & lang wasn’t as robust as it should be--& neither worked for unauthenticated users. And speaking of not being robust, the Regex for language parsing has a bug in where if a user sends a script (such as Serbian that uses both Cyrillic & Latin, with code such assr-Latn-RS
), we can get a bug. That code wasn’t the easiest to read so I did a refactor on the block to use named captures as I think it’s easier to read/follow.This will likely be easiest to read by commit.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project.
I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩