Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nice UI for adding a contact through a Gateway #378

Merged
merged 8 commits into from Apr 19, 2017
Merged

Nice UI for adding a contact through a Gateway #378

merged 8 commits into from Apr 19, 2017

Commits on Apr 2, 2017

  1. Helper to list all gateways in the roster

    @singpolyma
    singpolyma committed Apr 2, 2017
    Copy the full SHA
    952d698 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. Display a drop-down box of all gateway options 

    If there are any.  Same as the old UI when there are no gateways.
    @singpolyma
    singpolyma committed Apr 3, 2017
    Copy the full SHA
    65177dd View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2017

  1. Fetch and store the gateway prompts

    @singpolyma
    singpolyma committed Apr 4, 2017
    Copy the full SHA
    cf3ff13 View commit details
    Browse the repository at this point in the history

  2. Update the UI prompt when a gateway is selected

    @singpolyma
    singpolyma committed Apr 4, 2017
    Copy the full SHA
    2854f1e View commit details
    Browse the repository at this point in the history

  3. Fall back to jid\20escaping or old-style escaping 

    If the Gateway doesn't actually support jabber:iq:gateway, use a
reasonable fallback.
    @singpolyma
    singpolyma committed Apr 4, 2017
    Copy the full SHA
    c01a518 View commit details
    Browse the repository at this point in the history

  4. Ensure values are strings 

    Otherwise we sometimes get errors about not being allowed to serialize
SimpleXML stuff.
    @singpolyma
    singpolyma committed Apr 4, 2017
    Copy the full SHA
    afa2647 View commit details
    Browse the repository at this point in the history

  5. Actually submit JID for translation 

    If we got a prompt back earlier, then we know that the gateway supports
jabber:iq:gateway.  So we send off the user input, and then re-run our
form handler on whatever comes back.

Don't dismiss the dialog right away in JavaScript, but wait for the
server to be really done first.
    @singpolyma
    singpolyma committed Apr 4, 2017
    Copy the full SHA
    cc297f2 View commit details
    Browse the repository at this point in the history

  6. Display translation errors from the gateway 

    The gateway may perform some validation on the user input, and we need
to show any errors to the user so they can correct their mistakes.
    @singpolyma
    singpolyma committed Apr 4, 2017
    Copy the full SHA
    859ff1a View commit details
    Browse the repository at this point in the history