Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ad-hoc commands on contacts who support them #395

Merged

Conversation

singpolyma
Copy link
Contributor

@singpolyma
Copy link
Contributor Author

Because there was some concern about what this looks like if it's "always included", here are some screenshots of what it looks like.

Most contacts will look exactly the same as they do now:

screenshot - 06172017 - 10 18 14 am

But contacts that represent services will also show the available commands:

screenshot - 06172017 - 09 44 22 am

I think this UX is nicer that requiring a second click to get at the commands, and it won't affect most users at all since the page is exactly the same as now when there are no commands. If we did require clicking a sidebar item to get at the commands, where should they go? In a modal, I suppose?

@edhelas let me know what you think. I am willing to change it to a sidebar button, or whatever you prefer, but thought I should show the current design so we're sure it is needed before I build it.

@singpolyma singpolyma force-pushed the support-ad-hoc-commands-for-contacts branch from 0ccd3d4 to a82a1bc Compare June 17, 2017 17:09
@singpolyma
Copy link
Contributor Author

Based on conversation with @edhelas I have updated this PR to put the commands in the sidebar instead of the main area. Screenshot of it in action:

1

And here you see that normal contacts look the same as before:

2

And that the existing ad-hoc commands for the server also look the same as before:

3

@edhelas edhelas merged commit 70eac68 into movim:master Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants