Adding the timestamp column to the df returned by get_locations_at for a TrajectoryCollection #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding two tests to ensure proper execution.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=========================================
+ Coverage 0 95.43% +95.43%
=========================================
Files 0 33 +33
Lines 0 3572 +3572
=========================================
+ Hits 0 3409 +3409
- Misses 0 163 +163
☔ View full report in Codecov by Sentry. |
|
Great work. Could you please add a check to the test that ensures that the timestamps is the expected one? As far as I see, so far it only tests that the timestamps column exists |
…get_locations_at method for the TrajectoryCollection object
…get_locations_at method for the TrajectoryCollection object
… into enhancement/get_start_locations
|
This has now been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the timestamp column to the dataframe returned by the get_locations_at method of the TrajectoryCollection class. This has for consequence that the get_start_locations and get_end_locations now also return the timestamp column.
Solving: #318