Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin bar component is doing multiple HTTP requests #83

Closed
mitogh opened this issue Jun 14, 2016 · 3 comments
Closed

Admin bar component is doing multiple HTTP requests #83

mitogh opened this issue Jun 14, 2016 · 3 comments

Comments

@mitogh
Copy link
Member

mitogh commented Jun 14, 2016

Steps to reproduce and a minimal demo of the problem

Open the Chrome Inspector tool on the, Network tab.

Current behavior

The admin bar component is doing 3 requests.

Expected/desired behavior

Admin bar should do only one XHR request since the other 2 are not required

Other information

screen shot 2016-06-14 at 12 15 55 pm

@adamf321
Copy link
Contributor

this will fix it: moxie-lean/ng-web-app#63 (at least patch it up, there may be an actual issue causing it to make 3 calls)

@mitogh
Copy link
Member Author

mitogh commented Jun 14, 2016

I think the problem is a logic issue that creates 3 calls to the same APi. The cache willl still do 3 requests one to the API and 2 to the cache. So the main thing I guess is debug the component in order to just do one requests. Since this is happening on every page you visit so even if we use the cache as I mentioned before I think we are still experience the same problem.

@adamf321
Copy link
Contributor

Yes, agreed there's an issue. The cache would mask it, but not fix it.

andybar2 added a commit that referenced this issue Jun 29, 2016
Cached data to avoid multiple requests - Fix #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants