Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix paths being incorrectly normalized on unix #91

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Jan 31, 2018

This actually fixes another bug with options.cwd on Windows.

Closes #90.

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #91 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage    98.8%   98.86%   +0.06%     
==========================================
  Files           7        7              
  Lines         167      176       +9     
  Branches       35       38       +3     
==========================================
+ Hits          165      174       +9     
  Misses          2        2
Impacted Files Coverage Δ
lib/parse.js 96.22% <100%> (+0.07%) ⬆️
lib/util/resolveCommand.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334d705...06ee3c6. Read the comment docs.

@satazor satazor force-pushed the fix-unix-path-normalize branch 2 times, most recently from 923eeb9 to 2b6a686 Compare January 31, 2018 04:29
This actually fixes another bug with `options.cwd` on Windows.

Closes #90.
@satazor satazor merged commit 6f43a61 into master Jan 31, 2018
@satazor satazor deleted the fix-unix-path-normalize branch January 31, 2018 04:48
@evocateur
Copy link

Works great, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path.normalize(command) breaks local command on rebased cwd
2 participants