Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for updateTimeout before checking for unref #91

Conversation

mboperator
Copy link

Closes #90

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #91   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         192    192           
  Branches       48     48           
=====================================
  Hits          192    192
Impacted Files Coverage Δ
lib/lockfile.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb634b...b41400a. Read the comment docs.

@jessebmiller
Copy link

The bug that this PR mitigates, which I understand was not caused by proper-lockfile but can be mitigated here, was very hard and unintuitive to investigate and understand.

Future me would be appreciative not to have to figure it out again.

@hugomrdias
Copy link
Contributor

This is an old PR i'm going to close this! Feel free to reopen if it needs more discussion.
Check #90
Thank you.

@hugomrdias hugomrdias closed this Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError unref of undefined when running proper-lockfile inside of react-scripts test
3 participants