fixed path param replacement regex

moyukhbera · Apr 10, 2023 · aa772fb · aa772fb
1 parent 16fd360
commit aa772fb
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quick-validate",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "description": "Express middleware for codeless configuration-driven API validations",
   "main": "lib/index.js",
   "devDependencies": {

diff --git a/src/index.js b/src/index.js
@@ -60,7 +60,7 @@ export const setParamRouteValidations = (routesJSON) => {
     for (const httpMethod in routesJSON) {
         for (const url in routesJSON[httpMethod]) {
             if (url.indexOf(":") > -1) {
-                paramAuthRoutes[httpMethod][url.replace(/:[a-zA-Z0-9-_]+/g, "[a-zA-Z0-9-]+")] = routesJSON[httpMethod][url];
+                paramAuthRoutes[httpMethod][url.replace(/:[a-zA-Z0-9-_]+/g, "[a-zA-Z0-9-_]+")] = routesJSON[httpMethod][url];
             }
         }
     }

diff --git a/src/index.test.js b/src/index.test.js
@@ -102,7 +102,7 @@ test("setParamRouteValidations replaces param variable with regex", () => {
         }
     })).toStrictEqual({
         "GET": {
-            "/product/[a-zA-Z0-9-]+": {
+            "/product/[a-zA-Z0-9-_]+": {
 
             }
         },

diff --git a/src/quickValidate.js b/src/quickValidate.js
@@ -134,7 +134,7 @@ export const validate = (obj, validationConfig, reqPartName) => {
         }
 
         if (obj[fieldName] !== false && obj[fieldName] !== "" && !obj[fieldName]) {
-            return;
+            continue;
         }
 
         for (let key in fieldValidations) {