Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProblemData interface should inherit from Map<String, ProblemDataItem> #6

Closed
jfilak opened this issue Sep 19, 2013 · 1 comment
Closed

Comments

@jfilak
Copy link

jfilak commented Sep 19, 2013

Otherwise it doesn't make sense to define

abstract void add(String key, String value);

since the parent interface defines this method.

@mozeq
Copy link
Owner

mozeq commented Sep 24, 2013

After some discussion with jfilak we came to a conclusion that it's ok to implement Map<String, String>, but the class should follow the Map naming convention so additional methods are easy to find.

@mozeq mozeq closed this as completed in 0a3b423 Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants