Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testings #12

Merged

Conversation

daongochieu2810
Copy link
Collaborator

FeedbackResponseMonitorDbTest: test interval and duration of entities
FeedbackResponseRecordLogicTest: test initialization and purge method

Copy link
Owner

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The rest are a bit of nitpicking.
Fix the new ArrayList()

Copy link
Owner

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moziliar moziliar merged commit 96b55c2 into moziliar:code-task-main Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants