-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front end enhancements #16
Front end enhancements #16
Conversation
jianhandev
commented
Jan 31, 2021
- Drop down for response interval: for controlling the distance between data points, so that when duration is large, the data looks more spread out
- Toggle for different display modes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test as I cannot pull from target branch
beforeEach(async(() => { | ||
TestBed.configureTestingModule({ | ||
imports: [ | ||
HttpClientTestingModule, | ||
], | ||
}) | ||
.compileComponents(); | ||
})); | ||
beforeEach(() => { | ||
TestBed.configureTestingModule({}); | ||
service = TestBed.inject(FeedbackResponseStatsService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't the first beforeEach lambda merged into the second one?
import { AdminStatsPageComponent } from './admin-stats-page.component'; | ||
|
||
describe('AdminStatsPageComponent', () => { | ||
let component: AdminStatsPageComponent; | ||
let fixture: ComponentFixture<AdminStatsPageComponent>; | ||
|
||
beforeEach(async(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto