Fix remaining frontend issues for pagination #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teikjun
changed the title
teikjun
changed the title
|
Ready for review! |
| @@ -30,7 +30,7 @@ <h5 class="modal-title"> | |||
| <button type="button" class="btn btn-light modal-btn-cancel" *ngIf="!isInformationOnly" (click)="activeModal.dismiss()"> | |||
| {{ cancelMessage }} | |||
| </button> | |||
| <button type="button" class="btn modal-btn-ok" | |||
| <button type="button" class="btn modal-btn-ok z-index-1" | |||
There was a problem hiding this comment.
Instead of class z-index-1, how about style="z-index: 1" just to be cleaner
There was a problem hiding this comment.
Thanks for the review. I was also considering to inline the style as suggested!
However, I saw on line 13 (in the same file):
<span class="margin-left-5px" [innerHTML]="header"></span>So, I thought it would be better to be consistent with the convention used in the original code.
|
@moziliar Feel free to merge this into the main PR if everything looks fine! :) |
moziliar
merged commit 652eeed
into
moziliar:10959-paginate-frontend-call-to-webapi-for-large-course
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of TEAMMATES#10959, follow-up to #22.
Outline of Solution
Make requested changes to TEAMMATES#10960