Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate download when X button is pressed #24

Conversation

teikjun
Copy link

@teikjun teikjun commented Mar 6, 2021

Outline of Solution

  • Modify the behavior of X button to terminate the download

Remarks
Below is a record of the thought process, in case anyone revisits this part of the code.

  • Originally, X button does not terminate the download. The rationale was:
  1. If the user intentionally wants to close the modal to view other parts of the page while waiting, they can do so by intentionally hitting the X button.
  2. To avoid having two different looking UI components display the same behavior (Intuitively, things that look different should do different things)
  • Rationale for the change is to prevent weird UI interactions that may occur as a result of users messing around with UI during the download

@teikjun teikjun changed the title Make X button terminate the download Terminate download when X button is pressed Mar 7, 2021
@teikjun
Copy link
Author

teikjun commented Mar 8, 2021

@moziliar Feel free to merge this if it looks fine! :)

Copy link
Owner

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moziliar moziliar merged commit 8e83f5c into moziliar:10959-paginate-frontend-call-to-webapi-for-large-course Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants