This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 851262 - [email/IMAP] Bisection grow timezone logic generating zero-delta syncs that explode on gmail #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro-delta syncs that explode on gmail rs=squib This is squashed; here are the notable commit messages: :squib brought up a good point that it wasn't clear why I wasn't adding the timezone offset to the limit. Which caused me to realize that when dealing with NOW(), we indeed should be applying the timezone offset since our accuracy ranges are all centered around the local timezone of the server. Additional timezone fixes relating to NOW(): The previous commit did not go far enough. Specifically, all uses of NOW() turned out to be suspect and needing to be fixed where it dealt with accuracy ranges or talking with the server. This also entailed fixing makeDaysAgo to take the timezone offset, plus makeDaysBefore for when the date is null and it ends up calling makeDaysAgo. It was particularly important to calculate our effective end TS with the timezone offset for our bisection calculation. Otherwise, we ended up with the same bisection loop on 2 days. The other change is that when growing in the FUTUREWARDS direction, we also want to observe the highest legal endTS there too. We only differ in how we calculate the initial endTS, but we still don't want to name a date that's still in the relative future as our accuracy range, by definition, can't include it.
asutherland
added a commit
that referenced
this pull request
Mar 14, 2013
Bug 851262 - [email/IMAP] Bisection grow timezone logic generating zero-delta syncs that explode on gmail. rs=squib
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.