This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asutherland
added a commit
to asutherland/gaia
that referenced
this pull request
Jan 20, 2015
…pport, such as all CoreMail servers (ex: 126.com, 163.com) land mozilla-b2g/gaia-email-libs-and-more#358
asutherland
added a commit
to asutherland/gaia
that referenced
this pull request
Jan 20, 2015
…pport, such as all CoreMail servers (ex: 126.com, 163.com) land mozilla-b2g/gaia-email-libs-and-more#358
…pport, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav We: - Have the test variants imply specific fake-server configurations so that we can easily have all the IMAP tests run under a variety of fake-server configurations. - Make the move operation fall back to using message sequence numbers instead of the UID while trying to find out the new message's UID. This is the same thing we do for the IMAP prober which was the other place we had a UIDNEXT problem. Testing-wise: - I verified the test_mutation tests fail without the fix when using the nouidnext fake-server variant. - I changed the existing tests that used the imapExtensions mechanism as part of their test to instead use the new test variants. To make sure I didn't screw this up, I had the 2 existing tests add a check to ensure they were seeing the expected imapExtensions. Note that at least the prober test has other safe-guards to ensure the right path is used, since I did in fact make a refactoring dumb mistake and this wasn't entirely working to begin with!
asutherland
force-pushed
the
move-without-uidnext
branch
from
91d129b
to
fb8750c
Compare
asutherland
added a commit
that referenced
this pull request
Jan 21, 2015
Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9
asutherland
added a commit
to asutherland/gaia
that referenced
this pull request
Jan 21, 2015
…pport, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358
hwine
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 21, 2015
======== https://hg.mozilla.org/integration/gaia-central/rev/ecc956a27479 Author: Andrew Sutherland <asutherland@asutherland.org> Desc: Merge pull request #27513 from asutherland/email-uidnext-move Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 ======== https://hg.mozilla.org/integration/gaia-central/rev/f6a2b5666283 Author: Andrew Sutherland <asutherland@asutherland.org> Desc: Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358
rvandermeulen
pushed a commit
to mozilla-b2g/gaia
that referenced
this pull request
Jan 22, 2015
…pport, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358
hwine
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 22, 2015
======== https://hg.mozilla.org/integration/gaia-2_2/rev/28f22116c770 Author: Ryan VanderMeulen <ryanvm@gmail.com> Desc: Merge pull request #27546 from zbraniecki/1115796-add-langpacks-to-l10n-2.2 Bug 1115796 - Update l10n.js to use Langpacks API. r=stas ======== https://hg.mozilla.org/integration/gaia-2_2/rev/f6bc1f66f372 Author: Zibi Braniecki <gandalf@mozilla.com> Desc: Bug 1115796 - Update l10n.js to use Langpacks API. r=stas ======== https://hg.mozilla.org/integration/gaia-2_2/rev/c0f25a0e4e96 Author: Staś Małolepszy <stas@mozilla.com> Desc: Bug 1115797 - Extend languages list in Settings with Langpack provided locales. r=eragonj r=kgrandon r=gandalf ======== https://hg.mozilla.org/integration/gaia-2_2/rev/5d6960583e6d Author: Adrián de la Rosa <hola@adlr.es> Desc: Bug 1119738 - [Contacts] Pick vcard Activity should not return Facebook data ======== https://hg.mozilla.org/integration/gaia-2_2/rev/3801226b121a Author: mai <mri@tid.es> Desc: Bug 1105367 - [Usage] Some strings aren't automatically translated on language switch ======== https://hg.mozilla.org/integration/gaia-2_2/rev/1c4996572f9f Author: Andrew Sutherland <asutherland@asutherland.org> Desc: Bug 1120875 - Improved mem usage for fromTypedArray. r=andris9, r=asuth land mozilla-b2g/gaia-email-libs-and-more#360 ======== https://hg.mozilla.org/integration/gaia-2_2/rev/4a1b9e24b319 Author: Andrew Sutherland <asutherland@asutherland.org> Desc: Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358 ======== https://hg.mozilla.org/integration/gaia-2_2/rev/45c3c4eb94cf Author: jrburke <jrburke@gmail.com> Desc: Bug 1046799 - Include an option to manually configure email accounts without SSL ======== https://hg.mozilla.org/integration/gaia-2_2/rev/36640d189b1d Author: Kevin Grandon <kevingrandon@yahoo.com> Desc: Bug 1111524 - Add safety timeout for missing backdrop event r=etienne ======== https://hg.mozilla.org/integration/gaia-2_2/rev/14876d050d14 Author: Marcus Cavanaugh <m@mcav.com> Desc: Bug 839273 - [email] Offline moves can break sync of target folder. r=asuth ======== https://hg.mozilla.org/integration/gaia-2_2/rev/ff958e13defe Author: Alive Kuo <alegnadise@gmail.com> Desc: Bug 1121189 - Unset attention width on showing ======== https://hg.mozilla.org/integration/gaia-2_2/rev/ecc70348b6f5 Author: Steve Chung <schung@mozilla.com> Desc: Bug 1118215 - [Messages] ThreadUI.init takes too much time, r=azasypkin
asutherland
added a commit
to mozilla-b2g/gaia
that referenced
this pull request
Jan 27, 2015
…pport, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358
hwine
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 27, 2015
======== https://hg.mozilla.org/integration/gaia-2_1/rev/3eded6c57e5c Author: albertopq <albert.pastor@gmail.com> Desc: Bug 1121188 - Allowing pointer events on the attention screen chrome Conflicts: apps/system/test/marionette/lib/fakeloopapp.js apps/system/test/marionette/lib/utility_tray.js apps/system/test/marionette/utility_tray_gestures_test.js ======== https://hg.mozilla.org/integration/gaia-2_1/rev/107835ea479c Author: Andrew Sutherland <asutherland@asutherland.org> Desc: Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358 ======== https://hg.mozilla.org/integration/gaia-2_1/rev/dd7087db20e5 Author: albertopq <albert.pastor@gmail.com> Desc: Bug 1095677 - Activating utility tray on attention screen ======== https://hg.mozilla.org/integration/gaia-2_1/rev/30777554c433 Author: Jeff Muizelaar <jmuizelaar@mozilla.com> Desc: Bug 1042241 - Avoid encoding/decoding clip canvas r=kgrandon We can just paint the one canvas to the other directly. This avoids the png encoding/decoding time and will reduce peak memory.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 29, 2019
======== https://hg.mozilla.org/integration/gaia-central/rev/ecc956a27479 Author: Andrew Sutherland <asutherlandasutherland.org> Desc: Merge pull request #27513 from asutherland/email-uidnext-move Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 ======== https://hg.mozilla.org/integration/gaia-central/rev/f6a2b5666283 Author: Andrew Sutherland <asutherlandasutherland.org> Desc: Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358 UltraBlame original commit: ab493381ac2a6d181afd6b74ceb5c94bf1ececd1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 29, 2019
======== https://hg.mozilla.org/integration/gaia-central/rev/ecc956a27479 Author: Andrew Sutherland <asutherlandasutherland.org> Desc: Merge pull request #27513 from asutherland/email-uidnext-move Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 ======== https://hg.mozilla.org/integration/gaia-central/rev/f6a2b5666283 Author: Andrew Sutherland <asutherlandasutherland.org> Desc: Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358 UltraBlame original commit: ab493381ac2a6d181afd6b74ceb5c94bf1ececd1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 29, 2019
======== https://hg.mozilla.org/integration/gaia-central/rev/ecc956a27479 Author: Andrew Sutherland <asutherlandasutherland.org> Desc: Merge pull request #27513 from asutherland/email-uidnext-move Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 ======== https://hg.mozilla.org/integration/gaia-central/rev/f6a2b5666283 Author: Andrew Sutherland <asutherlandasutherland.org> Desc: Bug 1116694 - [email/IMAP] moves broken on servers without UIDNEXT support, such as all CoreMail servers (ex: 126.com, 163.com). r=mcav, r=andris9 land mozilla-b2g/gaia-email-libs-and-more#358 UltraBlame original commit: ab493381ac2a6d181afd6b74ceb5c94bf1ececd1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We:
we can easily have all the IMAP tests run under a variety of fake-server
configurations.
instead of the UID while trying to find out the new message's UID. This
is the same thing we do for the IMAP prober which was the other place we
had a UIDNEXT problem.
Testing-wise:
nouidnext fake-server variant.
part of their test to instead use the new test variants. To make sure
I didn't screw this up, I had the 2 existing tests add a check to
ensure they were seeing the expected imapExtensions. Note that at least
the prober test has other safe-guards to ensure the right path is used,
since I did in fact make a refactoring dumb mistake and this wasn't
entirely working to begin with!