Merge pull request #12309 from jmcanterafonseca/bug-917684

Bug 917684 - [Contacts] Importing from SIM a contact without phone numbe...
mozilla-b2g · Sep 19, 2013 · 0620108 · 0620108
2 parents 2216eb3 + 2ac3561
commit 0620108
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/apps/communications/contacts/js/utilities/import_sim_contacts.js b/apps/communications/contacts/js/utilities/import_sim_contacts.js
@@ -140,8 +140,19 @@ function SimContactsImporter() {
     for (var i = from; i < from + CHUNK_SIZE && i < self.items.length; i++) {
       var item = self.items[i];
       item.givenName = item.name;
-      for (var j = 0; j < item.tel.length; j++) {
-        item.tel[j].type = 'mobile';
+
+      if (Array.isArray(item.tel)) {
+        var telItems = [];
+
+        for (var j = 0; j < item.tel.length; j++) {
+          var aTel = item.tel[j];
+          // Filtering out empty values
+          if (aTel.value && aTel.value.trim()) {
+            aTel.type = 'mobile';
+            telItems.push(aTel);
+          }
+        }
+        item.tel = telItems;
       }
 
       item.category = ['sim'];