Bug 1134453 - [RTL] SMS notification for dual sim puts wrong parenthe…

…sis on wrong side of the sentence
mozilla-b2g · Mar 2, 2015 · 062d395 · 062d395
1 parent 28eb266
commit 062d395
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/apps/system/index.html b/apps/system/index.html
@@ -1054,7 +1054,7 @@ <h1 data-l10n-id="data-roaming-enabled-title"></h1>
       <div id="notification-toaster" data-z-index-level="notification-toaster" role="link" aria-live="assertive" aria-atomic="true" class="notification-toaster">
         <img id="toaster-icon" role="presentation" class="toaster-icon"/>
         <div id="notification-container">
-          <div id="toaster-title" class="toaster-title"></div>
+          <div id="toaster-title" class="toaster-title" dir="auto"></div>
           <div id="toaster-detail" class="toaster-detail"></div>
         </div>
       </div>

diff --git a/apps/system/js/notifications.js b/apps/system/js/notifications.js
@@ -460,6 +460,7 @@ var NotificationScreen = {
 
     var titleContainer = document.createElement('div');
     titleContainer.classList.add('title-container');
+    titleContainer.setAttribute('dir', 'auto');
 
     var title = document.createElement('div');
     title.classList.add('title');

diff --git a/apps/system/test/unit/notifications_test.js b/apps/system/test/unit/notifications_test.js
@@ -342,7 +342,10 @@ suite('system/NotificationScreen >', function() {
       assert.equal(dir, toaster.dir);
       var notificationNode =
         document.getElementsByClassName('notification')[0];
+      var notificationNodeTitle =
+        document.querySelector('.notification .title-container');
       assert.equal(dir, notificationNode.dir);
+      assert.equal('auto', notificationNodeTitle.dir);
     }
 
     test('calling addNotification with rtl direction', function() {