Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #27722 from eeejay/bug-1068998
Browse files Browse the repository at this point in the history
Bug 1068998 - Label video player buttons. r=djf
  • Loading branch information
eeejay committed Feb 4, 2015
2 parents 73435aa + 55f716f commit 0693417
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
1 change: 1 addition & 0 deletions apps/gallery/index.html
Expand Up @@ -20,6 +20,7 @@
<meta name="availableLanguages" content="ar, en-US, fr, zh-TW">
<link rel="localization" href="locales/gallery.{locale}.properties">
<link rel="localization" href="/shared/locales/date/date.{locale}.properties">
<link rel="localization" href="/shared/locales/media/media.{locale}.properties">
<!-- Shared code -->
<script defer src="shared/js/usertiming.js"></script>
<script defer src="shared/js/performance_testing_helper.js"></script>
Expand Down
15 changes: 10 additions & 5 deletions shared/js/media/video_player.js
Expand Up @@ -23,11 +23,14 @@ function VideoPlayer(container) {
container = document.getElementById(container);
}

function newelt(parent, type, classes) {
function newelt(parent, type, classes, l10n_id) {
var e = document.createElement(type);
if (classes) {
e.className = classes;
}
if (l10n_id) {
e.dataset.l10nId = l10n_id;
}
parent.appendChild(e);
return e;
}
Expand All @@ -36,9 +39,11 @@ function VideoPlayer(container) {
var poster = newelt(container, 'img', 'videoPoster');
var player = newelt(container, 'video', 'videoPlayer');
var controls = newelt(container, 'div', 'videoPlayerControls');
var playbutton = newelt(controls, 'button', 'videoPlayerPlayButton');
var playbutton = newelt(controls, 'button', 'videoPlayerPlayButton',
'playbackPlay');
var footer = newelt(controls, 'div', 'videoPlayerFooter hidden');
var pausebutton = newelt(footer, 'button', 'videoPlayerPauseButton');
var pausebutton = newelt(footer, 'button', 'videoPlayerPauseButton',
'playbackPause');
var slider = newelt(footer, 'div', 'videoPlayerSlider');
var elapsedText = newelt(slider, 'span', 'videoPlayerElapsedText');
var progress = newelt(slider, 'div', 'videoPlayerProgress');
Expand All @@ -47,8 +52,8 @@ function VideoPlayer(container) {
var playHead = newelt(progress, 'div', 'videoPlayerPlayHead');
var durationText = newelt(slider, 'span', 'videoPlayerDurationText');
// expose fullscreen button, so that client can manipulate it directly
var fullscreenButton = newelt(slider, 'button',
'videoPlayerFullscreenButton');
var fullscreenButton = newelt(slider, 'button', 'videoPlayerFullscreenButton',
'playbackFullscreen');

this.poster = poster;
this.player = player;
Expand Down
4 changes: 4 additions & 0 deletions shared/locales/media/media.en-US.properties
@@ -0,0 +1,4 @@
# Video controls
playbackPlay.ariaLabel=Play
playbackPause.ariaLabel=Pause
playbackFullscreen.ariaLabel=Fullscreen

0 comments on commit 0693417

Please sign in to comment.