Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #23052 from eliperelman/bug-1054716
Browse files Browse the repository at this point in the history
Bug 1054716 - Prevent system notification banners from overlaying the software home button
  • Loading branch information
rvandermeulen committed Aug 30, 2014
2 parents b98e39c + f119d87 commit 27fd427
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
5 changes: 5 additions & 0 deletions apps/system/style/system/system.css
Expand Up @@ -336,6 +336,11 @@ body {
transform: translateY(100%);
}

/* Banner should be offset when software home button is enabled */
#screen.software-button-enabled .generic-dialog.banner {
bottom: 5rem;
}

.generic-dialog.banner.visible {
animation: banner-bounce 4s;
visibility: visible;
Expand Down
11 changes: 7 additions & 4 deletions apps/system/style/zindex.css
Expand Up @@ -53,6 +53,12 @@
z-index: 65536;
}

/* Software home button should have higher z-index than system notification
banners to keep from being overlaid */
#screen > [data-z-index-level="software-buttons"] {
z-index: 65537;
}

/* Promote the transitioning appWindow to this level as the entry and exiting
* transition of the cards view. */
#screen.cards-view:not(.task-manager) > [data-z-index-level="app"] > .appWindow.active:not(.homescreen),
Expand Down Expand Up @@ -86,10 +92,7 @@
z-index: 32768;
}


#screen > [data-z-index-level="keyboards"],
#screen > [data-z-index-level="software-buttons"] {

#screen > [data-z-index-level="keyboards"] {
/* It should lower than UtilityTray's, to let the tray overlay it
in some situation like selecting a new keyboard. */
z-index: 4094;
Expand Down

0 comments on commit 27fd427

Please sign in to comment.