Merge pull request #32531 from benfrancis/1215926

Bug 1215926 - Fix strings in pin dialog r=albertopq

apps/system/js/app_chrome.js

@@ -407,6 +407,7 @@
     Service && Service.request('Places:setPinned', this.app.config.url, true)
       .then(() => {
       this.app.debug('Succeeding in pinning ' + this.app.config.url);
+      this.systemBanner.show('page-pinned-to-home-screen');
       var screenshotBlob = this.app.getCachedScreenshotBlob();
       if (screenshotBlob) {
         Service.request('Places:saveScreenshot', this.app.config.url,

apps/system/js/pin_page_system_dialog.js

@@ -128,7 +128,6 @@
     switch (action) {
       case 'pin':
         activeApp.appChrome.pinPage();
-        this._banner.show();
         break;
 
       case 'pin-site':
@@ -173,7 +172,7 @@
           this.pinSiteButton.setAttribute('data-l10n-id', 'pinning-unpin-site');
           this.pinSiteButton.dataset.action = 'unpin-site';
         } else {
-          this.pinSiteButton.setAttribute('data-l10n-id', 'pinning-pin');
+          this.pinSiteButton.setAttribute('data-l10n-id', 'pinning-pin-site');
           this.pinSiteButton.dataset.action = 'pin-site';
         }
       });

apps/system/locales/system.en-US.properties

@@ -647,11 +647,11 @@ pinning-unpin-type=Unpin "{{type}}"
 
 # LOCALIZATION NOTE (pinning-pin-page): This string is used as
 # panel title. "Pin" indicates the action to pin a page.
-pinning-pin-page=Pin Page
+pinning-pin-page=Pin page
 
 # LOCALIZATION NOTE (pinning-pin-site): This string is used as
 # panel title. "Pin" indicates the action to pin a site.
-pinning-pin-site=Pin Website
+pinning-pin-site=Pin site
 
 # LOCALIZATION NOTE (from): is followed (on a new line) by the URL source of
 # the pin. See also: https://bug1168948.bmoattachments.org/attachment.cgi?id=8639285
@@ -661,6 +661,8 @@ from=From
 site-pinned-to-home-screen=Site pinned to home screen
 # LOCALIZATION NOTE: Message shown in a banner after un-pinning a site
 site-unpinned-from-home-screen=Site unpinned from home screen
+# LOCALIZATION NOTE: Message shown in a banner after successfully pinning a page
+page-pinned-to-home-screen=Page pinned to home screen
 
 # LOCALIZATION NOTE (or): divider between pinning a page and a site.
 # See also: https://bug1214242.bmoattachments.org/attachment.cgi?id=8673636

apps/system/test/unit/pin_page_system_dialog_test.js

@@ -146,11 +146,6 @@ suite('Pin Page dialog', function() {
         assert.isTrue(stubPin.called);
       });
 
-      test('shows the banner', function() {
-        subject.pinButton.dispatchEvent(new CustomEvent('click'));
-        assert.isTrue(toastStub.show.called);
-      });
-
       test('saves the pinned site', function() {
         subject.pinSiteButton.dispatchEvent(new CustomEvent('click'));
         assert.isTrue(stubPinSite.called);