Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #32478 from JohanLorenzo/bug-1175080
Browse files Browse the repository at this point in the history
Bug 1175080 - Deactivate tests because of intermittent failures
  • Loading branch information
JohanLorenzo committed Oct 16, 2015
2 parents badac95 + 43daca2 commit ac8fba0
Showing 1 changed file with 18 additions and 11 deletions.
29 changes: 18 additions & 11 deletions tests/integration/sms/contacts_interaction_test.js
Expand Up @@ -69,10 +69,11 @@ marionette('Contacts', function() {
conversation = inbox.goToConversation(thread.id);
});

test('should create a new contact', function() {
// Bug 1175080. Sometimes Marionette looses the connection. Asserting on
// the throw makes the error message clearer. Otherwise we just have a
// crahs in the stackwalk.
// Deactivated because of bug 1175080. Sometimes Marionette looses the
// connection, which is making some intermittent Gij runs.
test.skip('should create a new contact', function() {
// Bug 1175080. Asserting on the throw makes the error message clearer.
// Otherwise we just have a crash in the stackwalk.
assert.doesNotThrow(function() {
var newContact = conversation.openCreateNewContact();

Expand All @@ -88,14 +89,20 @@ marionette('Contacts', function() {
});
});

test('should add the phone number to an existing contact', function() {
var contactPicker = conversation.openAddToExistingContact();
contactPicker.tapContact(testContact.name);
contactPicker.tapUpdate();
messagesApp.switchTo();
// Deactivated because of bug 1175080. Sometimes Marionette looses the
// connection, which is making some intermittent Gij runs.
test.skip('should add the phone number to an existing contact', function() {
// Bug 1175080. Asserting on the throw makes the error message clearer.
// Otherwise we just have a crash in the stackwalk.
assert.doesNotThrow(function() {
var contactPicker = conversation.openAddToExistingContact();
contactPicker.tapContact(testContact.name);
contactPicker.tapUpdate();
messagesApp.switchTo();

assert.equal(conversation.carrierHeaderPhoneNumber, '+123');
assert.equal(conversation.headerTitle, testContact.name);
assert.equal(conversation.carrierHeaderPhoneNumber, '+123');
assert.equal(conversation.headerTitle, testContact.name);
});
});
});

Expand Down

0 comments on commit ac8fba0

Please sign in to comment.