Merge pull request #31253 from albertopq/1178241-backout

Revert "Bug 1178241 - [vCard] 'undefined' is displayed when a field exist but there's no value in it r=borjasalguero"
mozilla-b2g · Aug 5, 2015 · b57e9a0 · b57e9a0
2 parents 283e40f + 5afb1cf
commit b57e9a0
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 22 deletions.
diff --git a/apps/communications/contacts/test/unit/vcard_parsing_test.js b/apps/communications/contacts/test/unit/vcard_parsing_test.js
@@ -671,16 +671,5 @@ suite('vCard parsing settings', function() {
         });
       });
     });
-    test('- vcard with fields with empty values', function(done) {
-      initializeVCFReader('vcard_undefined.vcf', function(reader) {
-        reader.onread = stub();
-        reader.onimported = stub();
-        reader.onerror = stub();
-        reader.process(function(result) {
-          sinon.assert.length(result, 1);
-          sinon.assert.length(result[0].org, 0);
-        });
-      });
-    });
   });
 });
diff --git a/apps/communications/contacts/test/unit/vcards/vcard_undefined.vcf b/apps/communications/contacts/test/unit/vcards/vcard_undefined.vcf
diff --git a/shared/js/contacts/import/utilities/vcard_parser.js b/shared/js/contacts/import/utilities/vcard_parser.js
@@ -472,10 +472,6 @@ var VCFReader = (function _VCFReader() {
 
       var v = vcardObj[field][0];
 
-      if (!v || !Array.isArray(v.value) || v.value.length === 0) {
-        return;
-      }
-
       var dateValue;
       if (field === 'bday') {
         dateValue = v.value[0];