Merge pull request #14422 from etiennesegonzac/bug-943236-edge-gestur…

…e-logic Bug 943236 - Move the current app to the top of the stack if the app opens a window. r=alive
mozilla-b2g · Dec 10, 2013 · c952e27 · c952e27
2 parents 60dc82e + 65db7ce
commit c952e27
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/apps/system/js/stack_manager.js b/apps/system/js/stack_manager.js
@@ -53,23 +53,24 @@ var StackManager = {
         if (app.stayBackground) {
           this._insertBelow(app);
         } else {
+          this._moveToTop(this._current);
           this._insertOnTop(app);
         }
         break;
       case 'launchapp':
       case 'launchwrapper':
         var config = e.detail;
         if (!config.stayBackground) {
+          this._moveToTop(this._current);
+
           var idx = this._indexOfURL(config.url);
           if (idx !== undefined) {
             this._moveToTop(idx);
           }
         }
         break;
       case 'home':
-        if (this._stack.length > 1) {
-          this._moveToTop(this._current);
-        }
+        this._moveToTop(this._current);
         break;
       case 'appterminated':
         var manifestURL = e.detail.manifestURL;
@@ -92,6 +93,10 @@ var StackManager = {
   },
 
   _moveToTop: function sm_moveToTop(index) {
+    if (index >= this._stack.length) {
+      return;
+    }
+
     var sheet = this._stack.splice(index, 1)[0];
     this._current = this._stack.push(sheet) - 1;
   },

diff --git a/apps/system/test/unit/stack_manager_test.js b/apps/system/test/unit/stack_manager_test.js
@@ -175,6 +175,22 @@ suite('system/StackManager >', function() {
         assert.deepEqual(StackManager.getPrev(), dialer);
         assert.deepEqual(StackManager.getCurrent(), contact);
       });
+
+      suite('then we go back and launch a third app', function() {
+        setup(function() {
+          StackManager.goPrev();
+          appLaunch(settings);
+        });
+
+        test('the current app at the time of the launch should move to the top',
+        function() {
+          assert.deepEqual(StackManager.getPrev(), dialer);
+        });
+
+        test('the new app should go on the top', function() {
+          assert.deepEqual(StackManager.getCurrent(), settings);
+        });
+      });
     });
 
     suite('if it\'s already in the stack', function() {
@@ -185,10 +201,18 @@ suite('system/StackManager >', function() {
 
       test('it should go on top of the stack', function() {
         appLaunch(dialer, true);
+
         assert.deepEqual(StackManager.getCurrent(), dialer);
         assert.deepEqual(StackManager.getPrev(), settings);
       });
 
+      test('it should bring the current app on top too', function() {
+        StackManager.goPrev();
+        appLaunch(dialer, true);
+
+        assert.deepEqual(StackManager.getPrev(), contact);
+      });
+
       test('it should not be duplicated', function() {
         appLaunch(dialer, true);