Merge pull request #30793 from bevis-tseng/Bug_1167507

Bug 1167507 - Wrap the input of the FDN Contact to MozIcc.updateContact() as a mozContact. r=evelyn
mozilla-b2g · Jul 9, 2015 · d8e68a7 · d8e68a7
2 parents 260118e + 4c7e6ba
commit d8e68a7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/apps/settings/js/modules/fdn_context.js b/apps/settings/js/modules/fdn_context.js
@@ -83,7 +83,7 @@ define(function() {
      * @param {String} action
      * @param {Number} options.cardIndex
      * @param {Object} options.contact
-     * @return {Object}
+     * @return {mozContact}
      */
     createAction: function(action, options) {
       var simContact = {};
@@ -109,7 +109,13 @@ define(function() {
           simContact.tel[0].value = '';
           break;
       }
-      return simContact;
+
+      var result = new window.mozContact(simContact);
+      if ('id' in simContact) {
+        result.id = simContact.id;
+      }
+
+      return result;
     }
   };
 

diff --git a/tests/atoms/gaia_data_layer.js b/tests/atoms/gaia_data_layer.js
@@ -110,7 +110,12 @@ var GaiaDataLayer = {
     var iccId = window.navigator.mozIccManager.iccIds[0];
     var icc = window.navigator.mozIccManager.getIccById(iccId);
 
-    var req = icc.updateContact(aType, aContact);
+    var simContact = new window.mozContact(aContact);
+    if ('id' in aContact) {
+      simContact.id = aContact.id;
+    }
+
+    var req = icc.updateContact(aType, simContact);
     req.onsuccess = function() {
       console.log('success saving contact to SIM');
       marionetteScriptFinished(req.result);