This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 870726 - [Camera] Confirmation of successful Image pick for email attachments and wallpaper #10246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (showSaving) { | ||
| cancelButton.classList.add('hidden'); | ||
| var savingSpinner = document.getElementById('saving-pick'); |
There was a problem hiding this comment.
Can we remove the saving spinner, I think its distracting and the reason for adding it isnt needed since we now have this confirmation step
… attachments and wallpaper; r=daleharvey
|
Ok, I've addressed the review comments and made the X button turn gray while we're processing the picture. I'm just going to wait for Travis to finish up and then land this. |
|
Only failure is a lint error in another app, so merging... |
jimporter
pushed a commit
that referenced
this pull request
Jun 6, 2013
Bug 870726 - [Camera] Confirmation of successful Image pick for email attachments and wallpaper
jimporter
pushed a commit
that referenced
this pull request
Jun 14, 2013
Bug 870726 - [Camera] Confirmation of successful Image pick for email attachments and wallpaper(cherry picked from commit 3434257) Conflicts: apps/camera/index.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.