This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 887564: Do not show phone # in name edit field #10673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the contacts_list code would overwrite the givenName field in the contact object. This was done so that different values could be shown in the list if a name was not present. This causes problems, though, when the contact object is shared between multiple parts of the app. In this case the contacts_form code was getting handed one of these modified contact objects. Modify the code to calculate the display name, but not modify the contact object itself. Also refactor how contacts_list refresh() works when given a contact object instead of an ID. The previous code was a bit confusing and called remove() twice for objects.
arcturus
added a commit
that referenced
this pull request
Jun 28, 2013
Bug 887564: Do not show phone # in name edit field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the contacts_list code would overwrite the givenName field in
the contact object. This was done so that different values could be
shown in the list if a name was not present. This causes problems, though,
when the contact object is shared between multiple parts of the app. In
this case the contacts_form code was getting handed one of these modified
contact objects.
Modify the code to calculate the display name, but not modify the contact
object itself. Also refactor how contacts_list refresh() works when given
a contact object instead of an ID. The previous code was a bit confusing
and called remove() twice for objects.