Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

ian-liu
Copy link
Contributor

@ian-liu ian-liu commented Jul 1, 2013

  • To test this patch on HVGA / WVGA devices:
  1. $ make install-gaia APP=fm GAIA_DEV_PIXELS_PER_PX=1.5

What GAIA_DEV_PIXELS_PER_PX do is to replace image files by @1.5x assets when exist.
Images will be too large (and break the layout) if we missed to set background-size for them in the patch.
If this patch works well, we will get correct layout on both HVGA and WVGA (and ideally qHD, but AFAIK we don't have to confirm it at this time) screen.

  • Testing on nightly is also possible:
  1. $ make DEBUG=1 GAIA_DEV_PIXELS_PER_PX=1.5
  2. enter about:config and set layout.css.devPixelsPerPx to 1.5
  3. set responsive design window to 320 x 533 px (which is CSS pixel dimension for 480 x 800 device pixel dimension).

But, of course, for apps using specific APIs, not all features can be tested.

@@ -4,6 +4,7 @@
<meta charset="utf-8">
<meta http-equiv="pragma" content="no-cache">
<title>Clock</title>
<!-- multi-resolution support -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was for responsive.css which is no longer needed, we can remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! It should be removed.

@rexboy7
Copy link
Contributor

rexboy7 commented Jul 2, 2013

Just curious, does these png files from L68-L87 no longer being used?
https://github.com/ian-liu/gaia/blob/7c6715623b162a2f6a13699a6d8bca653f2acfe4/apps/clock/style/clock.css#L68

@ian-liu
Copy link
Contributor Author

ian-liu commented Jul 3, 2013

Yes, these png files from L68-L87 won't be used again. There is no any Dom element for reference these file. They are all old clock app's document which was removed for a long time. :) I have just removed these CSS sheet too. Thanks for your reminder again.

@ian-liu
Copy link
Contributor Author

ian-liu commented Jul 3, 2013

Got r+ and revised useless comment. We can merge the pr now. Thanks for @rexboy7 's reviewing effort. It needs more patient for patch.

ian-liu added a commit that referenced this pull request Jul 3, 2013
…dpi_resolution_assets_and_layout_for_Clock_app

Bug 881139 - hdpi/xhdpi resolution assets and layout for Clock app, r=@rexboy7
@ian-liu ian-liu merged commit e099a11 into mozilla-b2g:v1.1.0hd Jul 3, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants