This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 893602 - hdpi/xhdpi resolution @1.5 assets for Camera app #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasolin
added a commit
that referenced
this pull request
Jul 22, 2013
Bug 893602 - hdpi/xhdpi resolution @1.5 assets for Camera app, r=rex
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this patch on HVGA / WVGA devices:
$ make install-gaia APP=camera GAIA_DEV_PIXELS_PER_PX=1.5
What GAIA_DEV_PIXELS_PER_PX do is to replace image files by @1.5x assets when exist.
Images will be too large (and break the layout) if we missed to set background-size for them in the patch.
If this patch works well, we will get correct layout on both HVGA and WVGA (and ideally qHD, but AFAIK we don't have to confirm it at this time) screen.
Testing on nightly is also possible:
$ make DEBUG=1 GAIA_DEV_PIXELS_PER_PX=1.5
enter about:config and set layout.css.devPixelsPerPx to 1.5
set responsive design window to 320 x 533 px (which is CSS pixel dimension for 480 x 800 device pixel dimension).
But, of course, for apps using specific APIs, not all features can be tested.