This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 908577 - Update JSZhuyin to the latest version with glue code #11709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $ ./tools/cook.sh /path/to/McBopomofo/Source/Data/data.txt | ||
|
|
||
| ./words.json and ./phrases.json will be updated. |
There was a problem hiding this comment.
Can we still maintain a simple README here and point to your upstream repo of jszhuyin instead of putting that info in pull.sh?
Thanks.
|
Can we remove the following files if they're not used? |
| if (code >= BOPOMOFO_START && code <= BOPOMOFO_END || | ||
| code === BOPOMOFO_TONE_1 || code === BOPOMOFO_TONE_2 || | ||
| code === BOPOMOFO_TONE_3 || code === BOPOMOFO_TONE_4 || | ||
| code === BOPOMOFO_TONE_5) { |
There was a problem hiding this comment.
Suggestion:
Create a array of BOPOMOFO_TONE_# and test if code in the that array.
There was a problem hiding this comment.
I liked it this way ✨
timdream
added a commit
that referenced
this pull request
Nov 11, 2013
Bug 908577 - Update JSZhuyin to the latest version with glue code, r=rudyl
timdream
added a commit
that referenced
this pull request
Nov 11, 2013
Bug 908577 - Update JSZhuyin to the latest version with glue code, r=rudyl (cherry picked from commit 8f8de16)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.