This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 922020 - Lazy load DOM nodes via HTML Import polyfill #12547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I saw your excellent work on Contacts I wanted to do the same on home app, thanks! |
| LazyLoader.load([document.getElementById('evmeOverlay'), | ||
| evmeContainer], function loaded() { | ||
| document.body.classList.add('evme-loading'); | ||
| navigator.mozL10n.translate(evmeContainer); |
There was a problem hiding this comment.
Here we translate evmeContainer, but not evmeOverlay. As evmeOverlay has strings I think we also need to translate it also?
If we are always loading these two together, it may be easier to place them within the same custom element? Not necessary, but it may be easier to call translate on a single node instead of two.
crdlc
pushed a commit
that referenced
this pull request
Oct 3, 2013
Bug 922020 - Lazy load DOM nodes via HTML Import polyfill
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=922020