bug 929643 - Python set device tests to fail on device type, remove fina... #13068
Conversation
|
Why no Travis CI? |
|
It did run although I've re-started it |
| @@ -3,4 +3,4 @@ | |||
| [test_calendar_today_date.py] | |||
| [test_calendar_new_event_appears_on_all_calendar_views.py] | |||
| # Bug #877611 - Make "Select time" popup, in Calendar app, more test friendly | |||
| xfail = true | |||
| disabled = true | |||
There was a problem hiding this comment.
Why are we disabling (skipping) these tests? If they're expected to fail we should use expected = fail
There was a problem hiding this comment.
Well I thought that is not a test that's going to turn green when that bug is fixed. The core problem is html structure and so forth in Gaia so even if they fixed that bug we'd still need to update the test.
Thus I thought I'd save the time of running what we know will fail!
There was a problem hiding this comment.
I didn't look at the test, so your comment may make sense. I'm fine with disabling (skipping) tests we don't want to run at all. :)
There was a problem hiding this comment.
Could we make the disabled reason the comment, so it's included in the reports? We can then also remove the comment.
disabled = Bug 877611 - Make "Select time" popup, in Calendar app, more test friendlyThere was a problem hiding this comment.
I will do it but this is pretty inconsistent, I mean you can do a reason like this but you can't do a reason for fail-if = , it's a bit crap.
|
Does this remove all xfail labels? If so, we should remove mention of them from the README. After merging we'll also need to update Jenkins and any documentation. |
|
Yes it removes the defaults, too. and Jenkins needs to be fixed up. Travis is taken care of in this pull. |
|
Force pushed the changes @davehunt |
In that case please also update the README as mentioned. I also just noticed that |
|
yeah that came in another commit. |
|
Done and cancelled the Travis job for the last commit |
|
Just a drive-by, pointy-haired comment: this is some kind of awesome :-) 👍 |
| @@ -14,4 +13,4 @@ xfail = false | |||
| [test_clock_set_alarm_snooze.py] | |||
| [test_clock_set_alarm_time.py] | |||
| # Bug 877611 - Make "Select time" popup, in Calendar app, more test friendly | |||
| xfail = true | |||
| disabled = true | |||
There was a problem hiding this comment.
As above regarding comment and skip reason.
|
Added a few more comments, sorry for missing these first time. I'd like to see the skip reasons updated, but not too concerned about the |
…inal traces of xfail
|
all address @davehunt |
|
Merged in afbf45f |
...l traces of xfail