Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 937105 - test_airplane_mode.py is failing #13580

Merged
merged 1 commit into from Nov 13, 2013

Conversation

bebef1987
Copy link
Contributor

No description provided.

@zacc
Copy link

zacc commented Nov 11, 2013

You know this ain't going to fly @bebef1987 ! (haha, sorry)

If the Settings app isn't ready for airplane mode to be switched on then we need to wait properly inside setings.launch() instead.

@zacc
Copy link

zacc commented Nov 12, 2013

    def enable_airplane_mode(self):
        checkbox = self.marionette.find_element(By.ID, "airplaneMode-input")
        self.wait_for_condition(lambda m: checkbox.is_enabled())
        label = self.marionette.find_element(*self._airplane_switch_locator)

        checkbox_state = checkbox.is_selected()

        label.tap()
        self.wait_for_condition(lambda m: checkbox_state is not checkbox.is_selected())

you have to wait for the checkbox to be enabled. the wait is a lot cleaner and also wait for the checkbox to be selected.
can you cannibalise this hack-code into this pull?

@@ -2,6 +2,8 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

import time
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@zacc
Copy link

zacc commented Nov 12, 2013

Some weirdness with WiFi not re-enabling so trying on Jenkins here:
http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui.adhoc/37/

@zacc
Copy link

zacc commented Nov 12, 2013

@bebef1987 it is a real bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=937752

let's see what movement is on tha tbug overnight and decide in the morning whether to xfail or not.

@zacc
Copy link

zacc commented Nov 13, 2013

I filed a separate bug for the xfail:
https://bugzilla.mozilla.org/show_bug.cgi?id=938083

zacc pushed a commit that referenced this pull request Nov 13, 2013
Bug 937105 - test_airplane_mode.py is failing
@zacc zacc merged commit e284dba into mozilla-b2g:master Nov 13, 2013
@bebef1987 bebef1987 deleted the fix_wifi branch November 28, 2013 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants