This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 929895 - Blacklist some apps of notifications removal #13691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,10 +146,19 @@ var NotificationScreen = { | |||
| } | |||
| }, | |||
|
|
|||
| // TODO: Workaround for bug 929895 until bug 890440 is addressed | |||
| clearBlacklist: ['app://wappush.gaiamobile.org/manifest.webapp'], | |||
There was a problem hiding this comment.
nit: use window.location.protocol instead of app://
There was a problem hiding this comment.
I'm not sure to understand ? As far as I read, the Gecko event that we get only contains a manifestURL.
Until bug 890440 is addressed, the system app clears all notifications related to an application when it is launched/displayed. This is not what we want for a couple of applications. We add a temporary hack to blacklist those, thus avoiding to clear notifications.
|
Travis is mostly green, only red is an unrelated failure. |
lissyx
added a commit
that referenced
this pull request
Nov 15, 2013
Bug 929895 - Blacklist some apps of notifications removal r=alive
lissyx
added a commit
that referenced
this pull request
Nov 21, 2013
Bug 929895 - Blacklist some apps of notifications removal r=alive (cherry picked from commit f7f616c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until bug 890440 is addressed, the system app clears all notifications
related to an application when it is launched/displayed. This is not
what we want for a couple of applications. We add a temporary hack to
blacklist those, thus avoiding to clear notifications.