This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
bug 945996 - cannot take screenshots in some devices because no home button #14329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,8 +195,8 @@ | |||
| fire('sleep'); | |||
| setState(baseState, type); | |||
| return; | |||
| case 'home-button-press': | |||
| fire('home+sleep'); | |||
| case 'volume-down-button-release': | |||
There was a problem hiding this comment.
Why release and not press? This way you have to hold home then press and release volume down. The following sequence would not work: press home, press vol down, release home, release vol down. And actually that sequence would presumably go to the homescreen even though the user is pretty obviously trying to do a screenshot here.
Am I missing something?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes volume-down+sleep the shortcut for screenshots.
Now always works for softbutton and tablet devices, and matches Android convention.