This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 948193 - Increase the timeout for testing wifi disable test (gaia-ui-test) #14555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davehunt @bobsilverberg @zacc -- and others, how does this patch look? |
|
I'm not in favour of hard-coding a timeout here. Simply specifying a |
|
The unittest.wifi job already has a timeout of 30000 set so this is actually lower than the timeout we've been using to catch this error. |
|
Already 30 seconds timeout? @@ Ok... Maybe I didn't actually reproduce the same error you met... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wifi disabling occasionally takes too long to complete and call back when doing test_wifi_settings.py. Simply increasing the timeout will solve this issue. But I really don't know how to pick a appropriate timeout....