WIP Bug 897600: Hook up the Firefox Accounts intro screen in the FTE #14618
Conversation
| @@ -351,6 +359,17 @@ var UIManager = { | |||
| settings.createLock().set(cset); | |||
| }, | |||
|
|
|||
| createFirefoxAccount: function ui_createFirefoxAccount() { | |||
| var showResponse = function showResponse(response) { | |||
| alert('Success: ' + JSON.stringify(response)); | |||
|
@borjasalguero - updated! |
|
@shane-tomlinson We would need some tests here! Please take a look! |
|
@borjasalguero - can somebody else, perhaps @6a68 take this over? I have very little bandwidth at the moment. |
|
I'm happy to take this over. @borjasalguero can you be a bit more specific about what tests you'd like to see? @SamPenrose do we have a bugzilla ticket in the tree for FTE work? I'm not sure how we want to prioritize this, I'll defer to you. |
|
@6a68 That would be awesome. The 1.4 version of 897600 is https://bugzilla.mozilla.org/show_bug.cgi?id=949063 . I am going to announce the big Bugzilla cleanup at the Thursday 8am PST meeting with TEF; assuming no objections I'll mark 897600 as dupe then. |
|
Relaunching Travis! |
|
@SamPenrose Sam, which bug is going to be the one for landing this feature? https://bugzilla.mozilla.org/show_bug.cgi?id=949063? If we are going to change to this we need to assign the bug properly, upload the patch and ask to review again. @shane-tomlinson Could you take a look? We have just landed FxA Module in master! :)! \m/ |
|
@borjasalguero I would like to do whatever is simplest. Can we land this under the current bug, then update the new bug as needed? |
|
@SamPenrose @borjasalguero I didn't realize changing the bug number would require another review; I've reopened 897600 to make life simpler :-) |
|
@shane-tomlinson This patch needs to solve as well the following: |
|
@borjasalguero just to be clear, do you think we must fix 935602 before landing this? If so, do you have any ideas how @6a68 can implement the disabling of hints? |
|
@SamPenrose fixing 935602 should be easy, we should be able to just add [1] http://www.otsukare.info/2013/12/03/form-spelling-feature |
|
@6a68 Yep! :) I would like to add this fix to this patch. As well we need to fix the test which is failing right now. I dont know if @shane-tomlinson has bandwith here, Jared could you sync with Shane? Maybe you can create a PR for this small fix and for making Travis become to green! Wdyt? |
|
@borjasalguero yes, i'm talking with shane and i'll just push to this branch with the extra tests and the x-inputmode fix |
|
arrrgh. I can't reproduce the travis failures locally, I'm guessing the timeout is because of travis VM slowness? @borjasalguero or @ferjm, would you mind restarting the travis job? |
|
auswerk restarted the travis job for me, it failed a second time. I can't repro the failures locally, working on that now. |
|
I really have no idea how to reproduce those failures locally. any advice @ferjm / @borjasalguero ? |
|
I figured out how to reproduce the error locally--it's not spurious. working on a fix. |
|
Sweet! Travis says tests passed, and I've added the fix for 935602. @borjasalguero does this look good to merge? |
|
@6a68 Jared, could you squash all commits into one? Thanks! |
|
@borjasalguero Sure, no problem. I've rebased against today's upstream and squashed everything into one commit. |
|
This PR was getting a bit stale, so I've rebased it again against 1/29 master. |
* Also fixes bug 935602 - disable autocorrect on inputs in firefox accounts
system app
|
Rebased again, this time against 2/19 master |
|
This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience. |
For @borjasalguero
https://bugzilla.mozilla.org/show_bug.cgi?id=897600